aprantl added inline comments.
================ Comment at: clang/test/CodeGenCXX/debug-info-template-align.cpp:8 + +// CHECK: DIDerivedType(tag: DW_TAG_typedef, {{.*}}, align: + ---------------- Do we need to hardcode the target here? Could we check for the specific align value? ================ Comment at: llvm/include/llvm/IR/DIBuilder.h:243 + unsigned LineNo, DIScope *Context, + uint32_t AlignInBits = 0); ---------------- This should be `Optional<uint32_t>` AlignInBits. Even better perhaps `llvm::Align` but perhaps that's too restrictive. ================ Comment at: llvm/include/llvm/IR/DIBuilder.h:244 + uint32_t AlignInBits = 0); /// Create debugging information entry for a 'friend'. ---------------- Do you need to update the C bindings as well? ================ Comment at: llvm/test/DebugInfo/X86/debug-info-template-align.ll:1 +; RUN: llc < %s -filetype=obj -o %t +; RUN: llvm-dwarfdump -v %t | FileCheck %s ---------------- `RUN: llc %s -filetype=obj -o - | llvm-dwarfdump -v - | FileCheck %s` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70111/new/ https://reviews.llvm.org/D70111 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits