dblaikie added inline comments.
================
Comment at: clang-tools-extra/clang-move/tool/ClangMove.cpp:113
move::MoveDefinitionSpec Spec;
- Spec.Names = {Names.begin(), Names.end()};
+ Spec.Names = (std::vector<std::string> &)Names;
Spec.OldHeader = OldHeader;
----------------
rnk wrote:
> Converting from std::list to SmallVector by way of std::vector with a C-style
> cast is a bit surprising. Is there a simpler way to write this, like
> `Spec.Names.assign(Names.begin(), Names.end());`?
Yep, +1 to assign(begin, end) & leaving SmallVector's API alone/not adding a
converting assignment operator.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69959/new/
https://reviews.llvm.org/D69959
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
