Tyker marked an inline comment as done. Tyker added inline comments.
================ Comment at: clang/lib/AST/TextNodeDumper.cpp:1349-1350 + } + OS << " subexpr"; + dumpPointer(D); +} ---------------- Tyker wrote: > rsmith wrote: > > We shouldn't need this: the address of the declaration is dumped anyway by > > the infrastructure. (If you meant to dump the subexpression, I don't think > > that's what this does.) > > > > Traversing from the `LifetimeExtendedTemporaryDecl` to its subexpression > > for dumping purposes should be done by `ASTNodeTraverser` (in > > `include/clang/AST/ASTNodeTraverser.h`). > I needed it during debugging and I thought i could be useful to others. but > yes it is unreachable from -ast-dump > > > If you meant to dump the subexpression, I don't think that's what this does. > it dumps the value of the pointer which can be used to know which > MaterializedTemporaryExpr it is associated with. ill add the traversal in the previous patch and remove subexpr here because it is better CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70190/new/ https://reviews.llvm.org/D70190 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
