kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
================
Comment at: clang-tools-extra/clangd/Selection.cpp:162
+ // Refs to operator() and [] are (almost?) always implicit as part of calls.
+ if (auto *DRE = llvm::dyn_cast<DeclRefExpr>(S))
+ if (auto *FD = llvm::dyn_cast<FunctionDecl>(DRE->getDecl()))
----------------
nit: braces
================
Comment at: clang-tools-extra/clangd/Selection.cpp:163
+ if (auto *DRE = llvm::dyn_cast<DeclRefExpr>(S))
+ if (auto *FD = llvm::dyn_cast<FunctionDecl>(DRE->getDecl()))
+ switch (FD->getOverloadedOperator()) {
----------------
nit: braces
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70194/new/
https://reviews.llvm.org/D70194
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
