johannes marked an inline comment as done.
johannes added inline comments.
================
Comment at: clang/lib/CodeGen/CGExpr.cpp:1021
void CodeGenModule::EmitExplicitCastExprType(const ExplicitCastExpr *E,
- CodeGenFunction *CGF) {
+ CodeGenFunction *const CGF) {
// Bind VLAs in the cast type.
----------------
nickie wrote:
> I don't think that `const` is necessary here. We're talking about the
> function's parameter. Why isn't `E` a `*const` too?
Right, this was left over from when I thought it was necessary. Removed the
`const` because it is surprising.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70302/new/
https://reviews.llvm.org/D70302
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
