plotfi marked an inline comment as done. plotfi added inline comments.
================ Comment at: clang/lib/Driver/Driver.cpp:3500 + PL = CompilePhaseList; + } + ---------------- compnerd wrote: > Do you use the `PhaseList` again? Why not `erase_if`? We tried this in getCompilationPhases. It didn't work very well. ================ Comment at: clang/lib/Driver/Driver.cpp:3506 + types::ID InputType = I.first; + const Arg *InputArg = I.second; + ---------------- compnerd wrote: > structured bindings ... so much. I don't understand? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70274/new/ https://reviews.llvm.org/D70274 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits