mprobst created this revision. mprobst added a reviewer: krasimir. Herald added a project: clang. Herald added a subscriber: cfe-commits.
Adds tests to ensure that `async method() ...` does not wrap between async and the method name, which would cause automatic semicolon insertion. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70377 Files: clang/unittests/Format/FormatTestJS.cpp Index: clang/unittests/Format/FormatTestJS.cpp =================================================================== --- clang/unittests/Format/FormatTestJS.cpp +++ clang/unittests/Format/FormatTestJS.cpp @@ -737,6 +737,22 @@ " function a() {\n" " return 1;\n" "} \n"); + // clang-format must not insert breaks between async and function, otherwise + // automatic semicolon insertion may trigger (in particular in a class body). + verifyFormat("async function\n" + "hello(\n" + " myparamnameiswaytooloooong) {\n" + "}", + "async function hello(myparamnameiswaytooloooong) {}", + getGoogleJSStyleWithColumns(10)); + verifyFormat("class C {\n" + " async hello(\n" + " myparamnameiswaytooloooong) {\n" + " }\n" + "}", + "class C {\n" + " async hello(myparamnameiswaytooloooong) {} }", + getGoogleJSStyleWithColumns(10)); verifyFormat("async function* f() {\n" " yield fetch(x);\n" "}");
Index: clang/unittests/Format/FormatTestJS.cpp =================================================================== --- clang/unittests/Format/FormatTestJS.cpp +++ clang/unittests/Format/FormatTestJS.cpp @@ -737,6 +737,22 @@ " function a() {\n" " return 1;\n" "} \n"); + // clang-format must not insert breaks between async and function, otherwise + // automatic semicolon insertion may trigger (in particular in a class body). + verifyFormat("async function\n" + "hello(\n" + " myparamnameiswaytooloooong) {\n" + "}", + "async function hello(myparamnameiswaytooloooong) {}", + getGoogleJSStyleWithColumns(10)); + verifyFormat("class C {\n" + " async hello(\n" + " myparamnameiswaytooloooong) {\n" + " }\n" + "}", + "class C {\n" + " async hello(myparamnameiswaytooloooong) {} }", + getGoogleJSStyleWithColumns(10)); verifyFormat("async function* f() {\n" " yield fetch(x);\n" "}");
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits