CodaFi added a comment. C binding changes LGTM. Don’t worry about changing them, they are marked as experimental and subject to change at any time.
================ Comment at: llvm/include/llvm-c/DebugInfo.h:878 LLVMMetadataRef File, unsigned LineNo, - LLVMMetadataRef Scope); + LLVMMetadataRef Scope, uint32_t AlignInBits); ---------------- sammccall wrote: > These functions in llvm-c are ABI-stable AFAIK. > (This broke the go bindings which are in-tree, but could equally break > out-of-tree bindings) The debug info bindings are not subject to the ABI stability guarantees of the rest of the C bindings to LLVM’s core. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70111/new/ https://reviews.llvm.org/D70111 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits