aganea added a comment.

Actually, I'm not sure the `DetectDistro()` does what it intends to do when 
cross-compiling: if I compile on Ubuntu and I forcibly specify `-target 
x86_64-linux` on the cmd-line, should it detect which Linux distro I'm on? 
Shouldn't it use the target triple, not the host triple? In the case of 
`CudaInstallationDetector()` it seems it should use the host triple, whereas in 
the case `clang/lib/Driver/ToolChains/Linux.cpp:Linux()` it adds flags for 
building the target, so it should take the target triple maybe. Should we pass 
a triple to `DetectDistro`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70467/new/

https://reviews.llvm.org/D70467



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D70467: [Distro] B... Alexandre Ganea via Phabricator via cfe-commits

Reply via email to