dblaikie added a comment. Seems to have a few things going on
- the title talks about global variables - the description talks about extern types (guessing that's just a typo?) - the patch itself seems to have code that's visiting more functions? ( processFuncPrototypes ) - & also I'd generally still prefer to see two patches for each piece of new debug info - first adding the functionality to LLVM, then second using that functionality in Clang (even though we're in the monorepo - these are still divisible patches that makes code review, revert, root cause analysis, etc, easier) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70625/new/ https://reviews.llvm.org/D70625 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
