aaron.ballman added inline comments.

================
Comment at: clang/lib/Parse/ParseStmt.cpp:1369-1370
         /*ShouldEnter=*/ConstexprCondition && *ConstexprCondition);
-    ElseStmt = ParseStatement();
+    if (Tok.is(tok::kw_if))
+      ElseStmt = ParseIfStatement(nullptr, ElseLoc);
+    else
----------------
This looks incorrect to me. Consider a case like:
```
if (0) {
} else [[gsl::suppress("foo")]] if (1) {
}
```
I'm a little uneasy calling anything but `ParseStatement()` here as that is 
what needs to be parsed at this stage.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70638/new/

https://reviews.llvm.org/D70638



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to