simon_tatham accepted this revision. simon_tatham added a comment. I do, but only an indentation quibble.
================ Comment at: clang/include/clang/Basic/arm_mve.td:205 + (select (icmp_ule $a, $b), $a, $b)>, + NameOverride<"vminq">; + def vmaxqu: Intrinsic<Vector, (args Vector:$a, Vector:$b), ---------------- It's a //ludicrously// minor nitpick, but if you could indent this `NameOverride` much further left, to indicate that it's a second base class alongside `Intrinsic` and not part of the template parameters //of// `Intrinsic`, that would be clearer. Same for the one below. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70829/new/ https://reviews.llvm.org/D70829 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
