yaxunl added inline comments.

================
Comment at: clang/test/SemaCUDA/deleting-dtor.cu:45-46
+
+// Only MS has diagnostic since MS requires deleting dtor is emitted when
+// vtable is emitted, even though dtor is not defined.
+namespace MSEmitDeletingDtor {
----------------
tra wrote:
> Nit: I think it should be `requires deleting dtor to be emitted` or `requires 
> that deleting dtor is emitted`
fixed


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70172/new/

https://reviews.llvm.org/D70172



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to