bryanpkc marked 6 inline comments as done. bryanpkc added inline comments.
================ Comment at: clang/test/OpenMP/openmp_offload_registration.cpp:3-5 +// RUN: %clang_cc1 -verify -fopenmp -x c -triple x86_64-unknown-linux-gnu -fopenmp-targets=aarch64-unknown-linux-gnu,powerpc64-ibm-linux-gnu -emit-llvm %s -o - | FileCheck %s +// RUN: %clang_cc1 -verify -fopenmp -x c -triple x86_64-unknown-linux-gnu -fopenmp-targets=i686-pclinux-gnu,powerpc-ibm-linux-gnu -emit-llvm %s -o - | FileCheck %s +// RUN: %clang_cc1 -verify -fopenmp -x c -triple x86_64-unknown-linux-gnu -fopenmp-targets=nvptx-nvidia-cuda,nvptx64-nvidia-cuda -emit-llvm %s -o - | FileCheck %s ---------------- ABataev wrote: > Do not add tests targets other than aarch64 OK, thank you. ================ Comment at: clang/test/OpenMP/target_messages.cpp:4 + +// RUN: not %clang_cc1 -fopenmp -std=c++11 -fopenmp-targets=aaa-bbb-ccc-ddd -o - %s 2>&1 | FileCheck %s // CHECK: error: OpenMP target is invalid: 'aaa-bbb-ccc-ddd' ---------------- ABataev wrote: > bryanpkc wrote: > > ABataev wrote: > > > Why do you need the changes in this file? > > The clean-up is not strictly necessary. I came across this file when I was > > looking for the right file to add the tests, and thought it would be better > > to group similar tests (and their corresponding CHECK patterns) together. > Do not do this in this patch, these changes are not related to the patch > itself. OK, I will remove these changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70804/new/ https://reviews.llvm.org/D70804 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
