MadCoder added inline comments.
================ Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:674 } Record.push_back(D->isInstanceMethod()); Record.push_back(D->isVariadic()); ---------------- arphaman wrote: > @MadCoder Given the fact that you're now setting SelfDecl and CmdDecl for > declarations, they need to be serialized properly. I would suggest the > following change to the writer: > > ``` > bool HasBody = D->getBody() != nullptr; > Record.push_back(HasBody); > if (HasBody) > Record.AddStmt(D->getBody()); > Record.AddDeclRef(D->getSelfDecl()); > Record.AddDeclRef(D-> getCmdDecl()); > ``` > > The AST reader should be updated accordingly. hah was the source of the last etst failure I was chasing, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71091/new/ https://reviews.llvm.org/D71091 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
