Eugene.Zelenko added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/bugprone/SignedCharMisuseCheck.cpp:22
+namespace {
+Matcher<TypedefDecl> hasAnyListedName(const std::string &Names) {
+ const std::vector<std::string> NameList =
----------------
Please use static for functions. See LLVM Coding Guidelines.
================
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:100
+
+ Finds ``signed char`` -> integer conversions which might indicate a
programming
+ error. The basic problem with the ``signed char``, that it might store the
----------------
One sentence is enough.
================
Comment at:
clang-tools-extra/docs/clang-tidy/checks/bugprone-signed-char-misuse.rst:73
+ an issue.
\ No newline at end of file
----------------
Please add newline.
================
Comment at:
clang-tools-extra/test/clang-tidy/checkers/bugprone-signed-char-misuse-with-option.cpp:75
+}
\ No newline at end of file
----------------
Please add newline.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71174/new/
https://reviews.llvm.org/D71174
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
