arphaman added inline comments.
================ Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:29 + + Ret.push_back("-fno-implicit-modules"); + Ret.push_back("-fno-implicit-module-maps"); ---------------- @Bigcheese It looks like there's some duplication in argument logic between this function and `getAdditionalCommandLine`. Can it be factored out into one function? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70268/new/ https://reviews.llvm.org/D70268 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits