pxli168 marked 2 inline comments as done.
pxli168 added a comment.
Remove test case for access quilifier in
test/SemaOpenCL/invalid-kernel-attrs.cl.
Due to the patch http://reviews.llvm.org/D17437.
read_only can only be used in parameters with pipe and image type.
================
Comment at: test/SemaOpenCL/invalid-pipe-builtin-cl2.0.cl:24
@@ -23,3 +23,3 @@
work_group_commit_read_pipe(p, tmp); // expected-error{{invalid argument
type to function work_group_commit_read_pipe (expecting 'reserve_id_t')}}
- sub_group_commit_write_pipe(p, tmp); // expected-error{{nvalid pipe
access modifier (expecting write_only)}}
}
----------------
Anastasia wrote:
> Anastasia wrote:
> > This test doesn't seem to work correctly because it didn't detect that we
> > were checking for the wrong error message!
> >
> > I am thinking it might be the issue of adding "-ferror-limit 100" to the
> > RUN line as it might have stopped to diagnose after certain number of
> > errors given. Could you please double check this?
> I just checked it and I guess it's passing because it's doing substring
> check, so no need to add anything to the RUN line. Your change is fine here!
I found these bug by testing with the access qualifier, and find some word
missing and just add them in this patch.
http://reviews.llvm.org/D16040
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
