efriedma added a comment. I'm not sure it's legal to transform a non-faulting load to a load with a non-faulting flag? At least, we'd need to consider the implications of that very carefully. In particular, I'm concerned about the interaction with intrinsics that read/write FFR. I mean, you could specify that loads marked MONonFaulting actually write to the FFR register, but that seems confusing.
It seems simpler to preserve the intrinsic until isel, at least for now. ================ Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:4490 + return getConstant(Val.zextOrTrunc(VT.getScalarSizeInBits()), DL, VT, + C->isTargetOpcode(), C->isOpaque()); + case ISD::SIGN_EXTEND: ---------------- I'm not sure how this is related. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71556/new/ https://reviews.llvm.org/D71556 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
