jdoerfert added a comment. In D71475#1784312 <https://reviews.llvm.org/D71475#1784312>, @cchen wrote:
> In D71475#1784284 <https://reviews.llvm.org/D71475#1784284>, @jdoerfert wrote: > > > What is the output when you run the example with `k` in `lastprivate` or > > `reduction`? > > > I actually got the same result (return value) changing from firstprivate to > lastprivate. Not so sure how to make linear work with reduction. I don't want it to "work" but I thought we should give a proper error message. Can you add test cases where a value is used in the step *and* in a (1) shared, (2) private, (3) firstprivate, ...? Other than that I think the code changes look pretty good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71475/new/ https://reviews.llvm.org/D71475 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
