rsmith marked 3 inline comments as done. rsmith added inline comments.
================ Comment at: clang/lib/AST/Type.cpp:1865-1866 // enumeration type in the sense required here. // C++0x: However, if the underlying type of the enum is fixed, it is // considered complete. if (const auto *ET = dyn_cast<EnumType>(CanonicalType)) ---------------- rsmith wrote: > rnk wrote: > > Is this C++11 comment still relevant? I assume that `isComplete` handles > > this case by returning true, and a forward decl can tell us if the enum is > > scoped. > I don't think this is useful -- and probably nor is the `isComplete` check. > I'll look into this in a follow-up commit. Fixed in rGeea8ba097c4a86632b88291bea51eb710f8ae4fb. Turns out this was hiding a bug in how we checked `static_cast<Enum>(...)` for incomplete enum types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71576/new/ https://reviews.llvm.org/D71576 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
