mstorsjo added a comment.

In D71650#1789897 <https://reviews.llvm.org/D71650#1789897>, @rjmccall wrote:

> Wow, that's novel.  Please add a comment explaining that this is a compiler 
> workaround, but otherwise LGTM.


The post-patch form doesn't look that odd to me (and we wouldn't want one 
comment for every one of the existing enums that already are outside of the 
structs where they are used for bitfield sizes), but do you think a comment is 
warranted here on this one?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71650/new/

https://reviews.llvm.org/D71650



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to