MadCoder added a subscriber: aprantl.
MadCoder added inline comments.
================
Comment at: clang/test/CodeGenObjC/direct-method.m:196
+@implementation Foo (Cat)
+// CHECK-LABEL: define hidden i32 @"\01-[Foo(Cat) directMethodInCategory]"(
+- (int)directMethodInCategory {
----------------
this may be questionable as a chosen mangling. it's exactly what dynamic
dispatch does, but because a direct method cannot have clashes on the same
class, this extra namespacing is not useful and is likely making the life of
debuggers harder for expression evaluation.
@aprantl should I generate `@"\01-[Foo directMethodInCategory]"` instead? if
yes I'd rather do it in this review
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71694/new/
https://reviews.llvm.org/D71694
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
