mstorsjo added a comment.

In D71572#1788786 <https://reviews.llvm.org/D71572#1788786>, @rnk wrote:

> Looks like @rsmith did this here:
>  
> https://github.com/llvm/llvm-project/commit/fbe2369f1a514423e4c25417ab3532502fde6f2a
>
> I see that it was replacing a CHECK for a specific comdat group with no 
> comdat at all. I *think* that's not correct, we should be checking for the 
> trivial comdat group, the one for the wrapper function, not the comdat group 
> of the TLS variable. Let's get input from Richard, though.


@rsmith?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71572/new/

https://reviews.llvm.org/D71572



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D71572: [... Martin Storsjö via Phabricator via cfe-commits

Reply via email to