aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM with a commenting request. ================ Comment at: clang-tools-extra/clang-tidy/utils/LexerUtils.h:95-97 +/// Assuming that ``Range`` spans a CVR-qualified type, returns the +/// token in ``Range`` that is responsible for the qualification. ``Range`` +/// must be valid with respect to ``SM``. Returns ``None`` if no qualifying ---------------- Should we add a comment that this is not for getting a member function qualifier? (I am assuming that case was never intended to work, but if it does work, should we also support ref qualifiers in that case?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71666/new/ https://reviews.llvm.org/D71666 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
