steakhal added inline comments.
================ Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:385 +unsigned getNumArgs(const CallEvent &Call) { + return Call.getNumArgs() + static_cast<unsigned>(isa<CXXInstanceCall>(Call)); } ---------------- I'm not sure why should we adjust (//workaround//) the number of arguments of `CXXInstanceCall`s calls, can someone explain it to me? The same question raised for `getArg` too. ================ Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:590 + CheckerContext &C) { + const auto *OCE = dyn_cast<CXXOperatorCallExpr>(Call.getOriginExpr()); if (OCE) { ---------------- I'm not sure if this is the right way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72035/new/ https://reviews.llvm.org/D72035 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits