spatel accepted this revision. spatel added a comment. This revision is now accepted and ready to land.
Code change LGTM - see inline for a question about the testing. ================ Comment at: clang/test/CodeGen/complex-libcalls.c:115-118 +// NO__ERRNO-NOT: .conj +// NO__ERRNO-NOT: @conj +// HAS_ERRNO-NOT: .conj +// HAS_ERRNO-NOT: @conj ---------------- Could we use positive matches for "fneg" here rather than NOT lines? If so, then do we need the new test file? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72028/new/ https://reviews.llvm.org/D72028 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
