tonyarnold added a comment.

Aside from the lack of tests, and `AllowNewlineBeforeBlockParameter` being 
outside of `BraceWrapping`, this is good! Much closer to how Apple's 
documentation and Xcode format blocks! 👍


================
Comment at: include/clang/Format/Format.h:421
@@ +420,3 @@
+  /// \brief If true, allow newlines before block parameters when ColumnLimit 
is 0.
+  bool AllowNewlineBeforeBlockParameter;
+
----------------
Perhaps this would be better placed within the custom `BraceWrapping` options? 
Something simpler like `BeforeBlockParameter`.


http://reviews.llvm.org/D17700



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to