logan-5 marked an inline comment as done.
logan-5 added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.h:59
+ struct FailureInfo {
+ std::string KindName; // Tag or misc info to be used as derived classes
need
+ std::string Fixup; // The name that will be proposed as a fix-it hint
----------------
JonasToth wrote:
> I think the `kind` should be an enum instead of stringly typing.
I can't disagree that the string is a little gross, but since the
interpretation of the string is for use by the derived classes, I don't think
an enum is flexible enough.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72213/new/
https://reviews.llvm.org/D72213
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
