adalava accepted this revision. adalava added a comment. This revision is now accepted and ready to land.
LGTM. Just a comment regarding FreeBSD 11.x. ================ Comment at: clang/test/Driver/ppc-abi.c:27 +// RUN: %clang -target powerpc64-unknown-freebsd12 %s -### 2>&1 | FileCheck --check-prefix=CHECK-ELFv1 %s +// RUN: %clang -target powerpc64-unknown-freebsd13 %s -### 2>&1 | FileCheck --check-prefix=CHECK-ELFv2-BE %s ---------------- FreeBSD 11.x (ELFv1) should be supported[1] until 2021. Maybe you would like to add a check for it too. [1]https://www.freebsd.org/security/security.html#sup ================ Comment at: clang/test/Preprocessor/init-ppc64.c:1060 + +// RUN: %clang_cc1 -E -dM -ffreestanding -triple=powerpc64-unknown-freebsd12 -target-abi elfv1 -xc /dev/null | FileCheck --check-prefix=PPC64-ELFv1 %s +// RUN: %clang_cc1 -E -dM -ffreestanding -triple=powerpc64-unknown-freebsd13 -target-abi elfv2 -xc /dev/null | FileCheck --check-prefix=PPC64-ELFv2 %s ---------------- same as above Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72352/new/ https://reviews.llvm.org/D72352 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
