krasimir requested changes to this revision. krasimir added inline comments. This revision now requires changes to proceed.
================ Comment at: clang/unittests/Format/FormatTestCSharp.cpp:257 + "}", + Style); + ---------------- Please also add a test for `SBPO_NonEmptyParentheses`. ================ Comment at: clang/unittests/Format/FormatTestCSharp.cpp:259 + + verifyFormat("using (StreamWriter sw = new StreamWriter(filenameB)) {}", + Style); ---------------- Can this appear at the top-level? If not, just keep the other test case to avoid confusion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72144/new/ https://reviews.llvm.org/D72144 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits