hans accepted this revision. hans added a comment. This revision is now accepted and ready to land.
Looks good to me (with a minor comment). Thanks! ================ Comment at: clang/tools/driver/driver.cpp:271 + unsigned long long Enable; + if (getAsUnsignedInteger(SpawnCC1Str, 10, Enable) || Enable > 1) { + llvm::errs() << "error: the value of the environment variable " ---------------- I think just checking SpawnCC1Str == "0" or == "1" would be easier. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69825/new/ https://reviews.llvm.org/D69825 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits