dgoldman requested changes to this revision. dgoldman added inline comments. This revision now requires changes to proceed.
================ Comment at: clang-tools-extra/clangd/unittests/SelectionTests.cpp:347 + )cpp", + "ObjCPropertyRefExpr"}, + ---------------- Please add a test for the case mentioned in https://github.com/clangd/clangd/issues/253 as well (for implicit property refs) even though it should also be a ObjCPropertyRefExpr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72634/new/ https://reviews.llvm.org/D72634 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits