gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:190 + // Set role for the node that may or may not be delayed. Node must span + // exactly \p Range. + void markMaybeDelayedChild(llvm::ArrayRef<syntax::Token> Range, NodeRole R); ---------------- Three slashes for docs. ================ Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:738 + U foo(); +}; + )cpp", ---------------- Could you also add an out-of-line definition of X::foo? It will have two template parameter lists, which is a special case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72334/new/ https://reviews.llvm.org/D72334 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
