dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land.
LGTM. ================ Comment at: clang/lib/Serialization/ModuleManager.cpp:183 // Get a buffer of the file and close the file descriptor when done. - Buf = FileMgr.getBufferForFile(NewModule->File, /*isVolatile=*/false); + Buf = FileMgr.getBufferForFile(NewModule->File, /*isVolatile=*/true); } ---------------- vsapsai wrote: > Made this change because if we don't have a valid module but opened a > corresponding .pcm file earlier, there is a high chance that .pcm file was > rebuilt. Please add a comment in the code explaining that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72860/new/ https://reviews.llvm.org/D72860 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits