andrew.w.kaylor added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2311
+ bool TrappingMath = true;
// overriden by ffp-exception-behavior?
bool RoundingFPMath = false;
----------------
arsenm wrote:
> cameron.mcinally wrote:
> > Last line of comment was not removed.
> >
> > Also, is it safe to remove `TrappingMathPresent`? Is that part of the
> > work-in-progress to support `ffp-exception-behavior`?
> I think this is a rebase gone bad. The patch changing the strict math was
> revered and recommitted and I probably broke this
Looks like this is still wrong. You didn't intend to change either TrappingMath
flag, did you?
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2657
// -fno_unsafe_math_optimizations restores default denormal handling
- DenormalFPMath = "";
+ DenormalFPMath = DefaultDenormalFPMath;
break;
----------------
Shouldn't this also restore DenormalFP32Math to its default value?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69878/new/
https://reviews.llvm.org/D69878
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
