DieGoldeneEnte added a comment. In D72806#1824560 <https://reviews.llvm.org/D72806#1824560>, @yaxunl wrote:
> What's the use case of this change? > > Normally clang needs to call opt/llc/lld from the same directory of clang. > Why do we need to find them in other directories? My motivation is the nix-package manager, which has llvm, lld and clang in different packages (which results in different directories). > Where is TOOLS_BINARY_DIR defined? If clang is compiled standalone with llvm as external library the TOOLS_BINARY_DIR is pulled from the LLVMConfig.cmake. If clang is compiled together with llvm the variable is set in the llvm/CMakeLists.txt . Upon closer inspection I noticed I can/should use LLVM_TOOLS_BINARY_DIR (which is more readable). In the end it points to the llvm/bin directory. > Also we cannot let the build fail because of lld not found, since users may > be building clang for other language and they do not need lld. Removed the message, so build doesn't fail. Since I check for the existence of the define in the code only the cmake rules needed to be changed. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72806/new/ https://reviews.llvm.org/D72806 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
