kkwli0 marked an inline comment as done. kkwli0 added inline comments.
================ Comment at: clang/docs/OpenMPSupport.rst:194 +------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+ -| device extension | requires directive (unified shared memory) | :good:`done` | | +| device extension | requires directive | :good:`done` | | +------------------------------+--------------------------------------------------------------+--------------------------+-----------------------------------------------------------------------+ ---------------- jdoerfert wrote: > ABataev wrote: > > We have support only for unified memory, so must be `partial` > Let's keep the explicit ` (unified shared memory) -> done ` line and add one > for the others as not done. @abataev It makes sense to make it `partial`. @jdoerfert Keeping that line can be confusing. Line 196 is clear to indicate that the unified_address and unified_shared_memory parts of the requires directive is done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72901/new/ https://reviews.llvm.org/D72901 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits