aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with a minor testing request, thank you!
================
Comment at: clang/test/Sema/attr-capabilities.c:12
-// Test an invalid capability name
-struct __attribute__((capability("wrong"))) IncorrectName {}; //
expected-warning {{invalid capability name 'wrong'; capability name must be
'mutex' or 'role'}}
-
----------------
I think it would be beneficial to have a test with an arbitrary capability name
other than role or mutex just to show that it's now explicitly allowed.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72635/new/
https://reviews.llvm.org/D72635
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
