MyDeveloperDay added a comment.
I think if you can fix the missing documentation it looks pretty good to go.
I do like the use of the static functions and the extensive test cases.. thank
you.
================
Comment at: clang/lib/Format/ContinuationIndenter.cpp:1442
+ // Search for any parameter that is a lambda
+ auto const *nextTok = Current.Next;
+ while (nextTok != nullptr) {
----------------
some people don't like the use of auto if the type isn't obvious,
I think by convention shouldn't this variable be `NextTok`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D44609/new/
https://reviews.llvm.org/D44609
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
