kpn marked an inline comment as done.
kpn added inline comments.
================
Comment at: clang/test/CodeGen/builtins-systemz-vector2-constrained.c:25
+ // CHECK: [[NEG:%[^ ]+]] = fneg <2 x double> {{.*}}
+ // CHECK: [[RES:%[^ ]+]] = call <2 x double>
@llvm.experimental.constrained.fma.v2f64(<2 x double> %{{.*}}, <2 x double>
%{{.*}}, <2 x double> [[NEG]], metadata !{{.*}}, metadata !{{.*}})
+ // CHECK: fneg <2 x double> [[RES]]
----------------
uweigand wrote:
> Why is it that this one has metadata nodes and all the others do not? Do
> they really not have metadata (why?) or are you just not checking for them?
No reason, really. The regular expression will pick up the second metadata
argument if present, so I could just eliminate the check for the second one
here. This isn't a metadata test so precise testing of metadata arguments
doesn't seem necessary? Consistency would be good, though.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72722/new/
https://reviews.llvm.org/D72722
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
