cchen marked an inline comment as done.
cchen added inline comments.
================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:15442-15443
+ CurComponents.emplace_back(CurE, nullptr);
+ } else if (auto *CurE = dyn_cast<BinaryOperator>(E)) {
+ E = CurE->getLHS()->IgnoreParenImpCasts();
} else {
----------------
cchen wrote:
> ABataev wrote:
> > Why just the LHS is analyzed? Also, what about support for other
> > expressions, like casting, call, choose etc., which may result in lvalue?
> 1. LHS: I'll fix that
> 2. I'll add support for casting, call, etc
> 3. For "choose" are you referring to something like (a < b ? b : a)?
For the handling of BinaryOperator, I'm not sure why should we handle RHS since
the possible source code I can imagine is `*(ptr+l)` or something like
`(ptr+l)[3]`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72811/new/
https://reviews.llvm.org/D72811
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
