david_stone added a comment.

In D72552#1832293 <https://reviews.llvm.org/D72552#1832293>, @rsmith wrote:

> Mechanically, this looks fine.
>
> There's an ongoing discussion in the committee as to whether this kind of 
> caching is permissible. But if this is necessary for acceptable performance, 
> let's take this for now and figure out how to invalidate the cache as 
> necessary later. Perhaps a `-f` flag to turn this off would be useful, so we 
> can demonstrate and measure the performance delta.


If there were a flag to turn this on and off, I would be happy to provide 
numbers for a real code base so we can understand how important of an 
optimization this is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72552/new/

https://reviews.llvm.org/D72552



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to