rsmith added a comment.

> An addition to the API will be concerned with ascending through the AST in 
> different traversal modes.

Ascending through the AST is not possibly by design. (For example, we share AST 
nodes between template instantiations, and statement nodes don't contain parent 
pointers.) Can you say more about what you're thinking of adding here?



================
Comment at: clang/include/clang/AST/ExprTraversal.h:1
+//===--- Expr.h - Classes for representing expressions ----------*- C++ 
-*-===//
+//
----------------
This needs an update.


================
Comment at: clang/lib/AST/ExprTraversal.cpp:1
+//===--- ExprTraversal.cpp - Expression AST Node Implementation 
-----------===//
+//
----------------
This header should briefly describe the purpose of this file. ("Simple 
expression traversal"?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73028/new/

https://reviews.llvm.org/D73028



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to