aaron.ballman added a comment.

In D72448#1844032 <https://reviews.llvm.org/D72448#1844032>, @njames93 wrote:

> Hmm a lot of the code in the redundant-string-init check is designed to be 
> macro unsafe. Not sure the best way to follow up, discard the old macro 
> behaviour or keep it


Designed to be macro unsafe, or just didn't consider macros in the first place? 
I'm not seeing anything that makes me think macros were taken into account, but 
maybe you're looking at something different from me. Do you have an example of 
where you think something was designed to be macro unsafe?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72448/new/

https://reviews.llvm.org/D72448



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to