ianlevesque marked 2 inline comments as done.
ianlevesque added inline comments.
================
Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:832
+ Fn->addFnAttr("xray-skip-exit");
+ }
+ if (!CGM.getCodeGenOpts().XRayInstrumentationBundle.has(
----------------
@hiraditya I realize on a previous diff you suggested dropping the brackets.
I'll do that here too.
================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1103
Opts.XRayIgnoreLoops =
- Args.hasArg(OPT_fxray_ignore_loops, OPT_fno_xray_ignore_loops, false);
+ Args.hasFlag(OPT_fxray_ignore_loops, OPT_fno_xray_ignore_loops, false);
----------------
MaskRay wrote:
> `Args.hasArg(OPT_fxray_ignore_loops);`
>
> There is no need to check a fno option in cc1, if the option is always
> enabled/disabled by default.
Will update.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73842/new/
https://reviews.llvm.org/D73842
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
