Charusso added inline comments.
================
Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:925
HighlightRange(R, LPosInfo.first, Range);
- }
}
----------------
Here the gray highlighting goes, so the `PopUpRanges` store whether we have
already highlighted the range and we early-continue. The cool thing is, we do
not check for intersections because the pop-up range has a smaller scope than
the entire expression's gray range so the HTML handles the colors/mouse-hover
for us. In case of macro pop-ups the coloring and-or pop-upping was already
buggy, they are handled differently, where I have not found such a cool
workaround.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73993/new/
https://reviews.llvm.org/D73993
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
