Szelethus added a comment.

I'm late to the party, but have looked at the code and I really, really-really 
like what you did in this patch! It solves one of my biggest complaints about 
this project. LGTM!



================
Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:1389
   HelpText<"Check the analyzer's understanding of C++ iterators">,
-  Dependencies<[IteratorModeling]>,
+  Dependencies<[DebugContainerModeling, IteratorModeling]>,
   Documentation<NotDocumented>;
----------------
This just works??? I admit that I didn't test very thoroughly whether multiple 
dependencies would work out, but I'm glad it does.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73547/new/

https://reviews.llvm.org/D73547



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to