hctim added inline comments.
================ Comment at: clang/docs/HardwareAssistedAddressSanitizerDesign.rst:73 +and performance overhead of the call is reduced by using a custom calling +convention that preserves most registers and is specialized to the register +containing the address and the type and size of the memory access. Currently, ---------------- Out of breath reading this sentence, maybe break up like: "...custom calling convention, which: 1. Preserves most registers, and 2. Is specialised based on the type and size of the memory access, as well as the register that contains the address." ================ Comment at: clang/docs/HardwareAssistedAddressSanitizerDesign.rst:148 + + * The address of each global has a static tag associated with it. These + tags are pseudo-random; they are computed using the hash of the path ---------------- * The first defined global in a translation unit has a pseudorandom tag associated with it, based on the hash of the file path. Subsequent global tags are incremental from the previously-assigned tag. ================ Comment at: clang/docs/HardwareAssistedAddressSanitizerDesign.rst:162 + + * An associated ``hwasan_globals`` section is emitted for each tagged global, + which indicates the address of the global, its size and its tag. ---------------- We have one section for all globals, right? So /s/section is emitted for each tagged global/section is emitted that contains information about the tagged globals/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74150/new/ https://reviews.llvm.org/D74150 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
