ABataev added inline comments.
================ Comment at: clang/include/clang/Driver/Options.td:3414-3416 +def fsycl : Flag<["-"], "fsycl">, Group<sycl_Group>, Flags<[NoArgumentUnused, CoreOption]>, HelpText<"Enable SYCL kernels compilation for device">; +def fno_sycl : Flag<["-"], "fno-sycl">, Group<sycl_Group>, Flags<[NoArgumentUnused, CoreOption]>, ---------------- These flags should not be ignored, `NoArgumentUnused` should be applied to this flags. ================ Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5304-5306 + // Forward -sycl-std option to -cc1 + Args.AddLastArg(CmdArgs, options::OPT_sycl_std_EQ); + ---------------- This code is not required, you already forwarded `sycl-std` to the frontend earlier ================ Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2549 + // but also those using the SYCL API + if (const Arg *A = Args.getLastArg(OPT_sycl_std_EQ)) { + Opts.setSYCLVersion( ---------------- I think processing of `sycl-std` in the frontend also must be controlled by some high-level option, like `-fsycl` or something like this. Without this `-fsycl`-like option this `std` option also must be ignored. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits